Skip to content

fix(config): support dynamic parameters for more FE params#1804

Open
dhable wants to merge 4 commits intomainfrom
dan/hdx-3510-use-next-runtime-env-for-dynamic-fe-config-params
Open

fix(config): support dynamic parameters for more FE params#1804
dhable wants to merge 4 commits intomainfrom
dan/hdx-3510-use-next-runtime-env-for-dynamic-fe-config-params

Conversation

@dhable
Copy link
Contributor

@dhable dhable commented Feb 25, 2026

The parameters around API key and instrumentation should be allowed to vary at runtime instead of requiring the values to be set at build time.

The parameters around API key and instrumentation should be allowed
to vary at runtime instead of requiring the values to be set at
build time.
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

🦋 Changeset detected

Latest commit: df7e7ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Minor
@hyperdx/api Minor
@hyperdx/otel-collector Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Feb 26, 2026 3:40pm

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

E2E Test Results

All tests passed • 72 passed • 4 skipped • 916s

Status Count
✅ Passed 72
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@github-actions
Copy link
Contributor

PR Review

⚠️ Semantic mismatch for non-NEXT_PUBLIC_ varsenv('HYPERDX_API_KEY') and env('HDX_EXPORTER_ENABLED') don't gain runtime dynamism from next-runtime-env (its injection mechanism is specifically for NEXT_PUBLIC_ vars via PublicEnvScript). These were already runtime-configurable as server-only env vars via process.env. The actual win in this PR is for NEXT_PUBLIC_OTEL_SERVICE_NAME and NEXT_PUBLIC_OTEL_EXPORTER_OTLP_ENDPOINT, which previously were baked in at build time. No bug is introduced since all four are only consumed in pages/api/config.ts (server-side), but the changeset description somewhat overstates the scope of what actually changes.

✅ No security issues — HYPERDX_API_KEY is not leaked to the client.

✅ No behavioral regression — server-side env() falls back to process.env, so API route output is identical to before.

Overall: safe to merge. Consider clarifying in the changeset that only the NEXT_PUBLIC_ vars are newly dynamic at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant