Skip to content

chore: separate timeline components to own modules, fix lint issues#1813

Merged
kodiakhq[bot] merged 2 commits intomainfrom
karl/timeline-components-refactor
Mar 4, 2026
Merged

chore: separate timeline components to own modules, fix lint issues#1813
kodiakhq[bot] merged 2 commits intomainfrom
karl/timeline-components-refactor

Conversation

@karl-power
Copy link
Contributor

@karl-power karl-power commented Feb 26, 2026

Closes HDX-3518

Changes

  • Separates the different Timeline related components into their own modules inside packages/app/src/components/TimelineChart.
  • Fixes lint and TS errors / warnings.

Testing

  • Trace waterfall view should work just like before.

@vercel
Copy link

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 4, 2026 8:21pm
hyperdx-v2-oss-app Ready Ready Preview, Comment Mar 4, 2026 8:21pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2026

🦋 Changeset detected

Latest commit: ced77a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@karl-power karl-power requested review from a team and knudtty and removed request for a team February 26, 2026 16:12
@karl-power karl-power force-pushed the karl/timeline-components-refactor branch from 965dd14 to 816d1dd Compare February 26, 2026 16:17
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

E2E Test Results

All tests passed • 75 passed • 4 skipped • 945s

Status Count
✅ Passed 75
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Claude finished @karl-power's task in 1m 17s —— View job


PR Review

✅ Clean refactoring overall — components are properly split and existing functionality is preserved. A few minor items to address:

  • ⚠️ Dead prop in TimelineChartRowEvents.tsx:31onEventClick?: (event: TTimelineEvent) => void is defined in the type but never destructured or used in the component. Remove it or wire it up. Fix this →

  • ⚠️ Self-referential null check in TimelineMouseCursor.tsx:39if (onMouseMove != null) checks the locally-defined onMouseMove function (always truthy). Remove the conditional, just call setXPerc(xPerc) directly. Fix this →

  • ⚠️ Unused variable in TimelineMouseCursor.tsx:33const y = e.clientY - rect.top; is computed but never used. Remove it. Fix this →

  • ℹ️ index.ts only re-exports TimelineChart — if consumers need TTimelineEvent or TTimelineSpanEventMarker types externally in the future, they'd need to import from internal paths. No issue now since no external consumers need them.

@karl-power karl-power force-pushed the karl/timeline-components-refactor branch from 131fc4c to 077a0f4 Compare March 4, 2026 10:03
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Claude finished @karl-power's task in 34s —— View job


PR Review

The three issues flagged in the previous review are still unresolved:

  • ⚠️ Dead prop TimelineChartRowEvents.tsx:31onEventClick? is declared in TimelineChartRowProps but never destructured or used in the component body. Remove it or wire it up. Fix this →

  • ⚠️ Self-referential null check TimelineMouseCursor.tsx:39if (onMouseMove != null) always evaluates to true (it checks the locally-defined onMouseMove function, not a prop). Remove the if wrapper and just call setXPerc(xPerc) directly. Fix this →

  • ⚠️ Unused variable TimelineMouseCursor.tsx:33const y = e.clientY - rect.top; is computed but never referenced. Remove it. Fix this →

Otherwise the refactor is clean — components are properly modularized and functionality is preserved.

@kodiakhq kodiakhq bot merged commit f889c34 into main Mar 4, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants