Add integration test scripts and CI workflows (Lint, Build, and Integration Tests)#5
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's testing infrastructure and continuous integration capabilities. It introduces a robust set of integration tests that validate the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive integration test suite using bash and swtpm, along with corresponding GitHub Actions workflows. This is a great addition for ensuring the tool's stability and correctness. The changes also include minor lint fixes in the Rust source code. My review focuses on the new test scripts, and I've provided a couple of suggestions to improve their robustness and clarity.
| SWTPM_PID=$! | ||
|
|
||
| # Wait for swtpm to be ready. | ||
| for _ in $(seq 1 20); do |
There was a problem hiding this comment.
The wait loop for swtpm has a fixed timeout of 2 seconds (20 * 0.1s). On a heavily loaded CI machine, swtpm might take longer to start up, which could lead to flaky tests when the script fails to connect to the socket. Consider increasing the timeout to make the tests more robust.
| for _ in $(seq 1 20); do | |
| for _ in $(seq 1 50); do |
There was a problem hiding this comment.
I will leave the code as-is until the identified issue actually occurs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d345476c93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds integration test scripts using the software TPM emulator swtpm. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
hyperfinitism
force-pushed
the
ci/lint-build-test
branch
from
d345476 to
3043329
Compare
1 participant
Changes
tests/) using swtpm (software TPM emulator) covering key lifecycle, attestation, ECC, NV, PCR, encryption/decryption, signing, sessions/policies, and morerustfmt+clippy), build (multi-arch matrix), and integration tests