Feat: implement result reporting for payloads buffer push#5443
Open
FirePheonix wants to merge 1 commit intohyperledger:mainfrom
Open
Feat: implement result reporting for payloads buffer push#5443FirePheonix wants to merge 1 commit intohyperledger:mainfrom
FirePheonix wants to merge 1 commit intohyperledger:mainfrom
Conversation
Signed-off-by: Shubham Singh <shubhsoch@gmail.com>
FirePheonix
force-pushed
the
fix-gossip-buffer-status
branch
from
e7b69c7 to
0ca006b
Compare
Contributor
Author
|
@pfi79 could you please review this one too.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Push method in the Gossip PayloadsBuffer returns nothing (a void).
This results in "silent drops" where payloads (blocks) are rejectedfor example, because they are duplicates or have outdated sequence numbers,without the caller or system operator being notified.
A TODO was left in the codebase suggesting that this should return a boolean to allow for better status reporting and logging.
This PR simply implements the suggested boolean return value for the Push operation to enhance the observability of the Gossip state transfer service.