Merged
Conversation
Deploying hyperterminal with
|
| Latest commit: |
3a031a3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fbd8dec2.hyperterminal.pages.dev |
| Branch Preview URL: | https://fix-deploy.hyperterminal.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React 19 Code Review Checklist
Use this checklist when reviewing PRs that modify React components.
useEffect Anti-Patterns
No derived state in useEffect - State calculated from props/other state should be computed during render, not in useEffect
No state reset in useEffect - Use
keyprop to reset component state when props changeNo localStorage/sessionStorage reads in useEffect - Initialize state from storage
No event handling logic in useEffect - Put it in event handlers
useEffect only for external system sync - WebSockets, DOM APIs, third-party libs
useMemo/useCallback
No useMemo for simple calculations - React 19 compiler handles this
No useCallback for simple event handlers - Unless passed to memoized children
Keep useMemo for expensive operations - Array sorting, filtering large datasets, complex transformations
React 19 Patterns
No forwardRef - Pass
refas regular propUse new hooks where applicable
useActionStatefor form state managementuseOptimisticfor optimistic UI updatesuseFormStatusto access parent form stateuse()to read promises in renderServer/Client Components
Performance
@tanstack/react-virtualfor 100+ itemsReact.lazy()withSuspenseReference: See
react-19-guidelines.mdfor detailed examples and explanations.