fix(ci): walker Js.Exn catch-arm detection + vscode E2E false-positive (closes #426)

[hyperpolymath]

Summary

Closes #426. Two small surgical fixes that resolve the 3 pre-existing test failures blocking PR auto-merges on main.

Fix 1 — Walker Js.Exn catch-arm detection (resolves 1 test)

tools/res-to-affine/walker.ml — drop the node.children = [] constraint from the fallback in detect_untyped_exception. tree-sitter-rescript parses Js.Exn.Error(_) in a catch-arm as a compound node (constructor pattern with the (_) payload as a child), so the leaf-only check skipped it.

The pre-existing 32-char text length cap is a sufficient guardrail — Js.Exn.Error(_) is 15 chars and the enclosing try/match expressions exceed the cap. Dedupe handles same-line duplicates.

Test: walker-phase2c-parity #2 untyped-exception [OK] (was FAIL).

Fix 2 — vscode E2E false-positive (resolves 2 tests)

packages/affine-vscode/mod.js — rewrite the manual-wiring example in the header doc comment. The previous text contained literal require(\"@hyperpolymath/affine-vscode\") and require(\"vscode-languageclient/node\") strings as illustrative code; once mod.js is embedded at compile time (per #380), the E2E codegen tests' substring-based contains helper false-positived on those comment strings.

New wording uses named placeholders (loadShim() / loadAdapter() / loadVscode() / loadLanguageClient()) plus an explanatory note saying the literal require(...) strings are intentionally omitted so the E2E assertions don't false-positive.

Tests:

• E2E Node-CJS Codegen #4 --vscode-extension-adapter-override [OK] (was FAIL)
• E2E Node-CJS Codegen #5 --vscode-extension-no-lc [OK] (was FAIL)

Verification (local)

# walker
dune build tools/res-to-affine/test/test_walker.exe
./_build/default/tools/res-to-affine/test/test_walker.exe
# Test Successful — 7 tests run, 0 failures

# vscode E2E
./_build/default/test/test_main.exe test \"E2E Node-CJS Codegen\"
# All [OK]

Test plan

• CI `build` job (was failing) → green
• CI `coverage-visibility` job → green
• No regression on other vscode/walker tests

🤖 Generated with Claude Code

[github-actions]

🔍 Hypatia Security Scan

Findings: 81 issues detected

Severity	Count
🔴 Critical	4
🟠 High	10
🟡 Medium	67

⚠️ Action Required: Critical security issues found!

View findings

[
  {
    "reason": "Action actions/checkout@v6 needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action denoland/setup-deno@v2 needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in affine-vscode-publish.yml",
    "type": "unknown",
    "file": "affine-vscode-publish.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "unknown",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "unknown",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence