feat(typecheck): module-qualified type/effect path resolution (ADR-014, Refs #228)

[hyperpolymath]

Summary

Symmetric to #178 (Resolve.lower_qualified_value_paths) at the value-path layer: when a folded Mod::T reaches lower_type_expr / lower_effect_expr, the leading Mod:: qualifier is stripped iff Mod was introduced by use Mod;. Otherwise a clear UnknownModule error is raised — replacing the pre-existing silent typecheck-pass (type position) and misleading declare \effect ...`` hint (effect position).

Closes the resolution half of the #228 work whose parser half landed in #241 (ADR-014).

What changes

• type_error: UnknownModule of string constructor + formatter (cites ADR-014/LANG: type/effect grammar has no module-qualified path — Pkg.Type/Pkg.Effect unrepresentable (estate-wide port blocker; ADR-014) #228, suggests use M; / use M::{Item};)
• Module_resolution_error exception caught at check_program boundary (mirrors Effect_validation_error)
• context.module_quals: populated at check_program entry from prog.prog_imports (ImportSimple only — matches value-path semantics in Resolve.import_qualifiers)
• strip_module_qualifier helper applied in TyCon / TyApp arms of lower_type_expr and the resolve helper of lower_effect_expr. No AST walk — the lowering chokepoints already visit every type/effect site.

Before / after

Source	Before	After
pub fn f(x: NoSuchMod.Thing) -> ()	silently passes typecheck	Unknown module 'NoSuchMod' in qualified type/effect reference (ADR-014, #228). Add \use NoSuchMod;` ...`
pub fn f() -{NoSuchMod.IO}-> ()	Unknown effect 'NoSuchMod::IO'. ... declare it with \effect NoSuchMod::IO;``	same UnknownModule text as above
use Ajv; pub fn f(x: Ajv.Schema) -> ()	passes (TyCon lenient)	passes (strip → bare lenient lookup, unchanged outcome)
pub fn f(x: Int) -> ()	passes	passes (regression guard)

Tests

test/test_qualified_paths.ml — 6 alcotest cases, all green:

• qualified type + use (both . and ::) → passes
• qualified type, no use → UnknownModule
• qualified effect, no use → UnknownModule (not UnknownEffect)
• bare TyCon unchanged
• qualified reserved effect (Net) + use → strips & resolves into the reserved-effect path

Full suite: dune build @test/runtest → 352/352 OK.

Out of scope (surfaced in #228 design comment)

These are real but separate; I'll file follow-ups if the seam-analyst note isn't already tracked elsewhere:

• lowercase-module qualified refs (json.Value) still parse-error — qualified_type_name head requires upper_ident while stdlib has lowercase module json; / option; / prelude;
• use A.B; registers only B as the qualifier (last segment)
• use A::{Item} (multi-segment + brace-list) parse-errors
• bare unknown TyCons silently pass typecheck — pre-existing leniency, much broader than LANG: type/effect grammar has no module-qualified path — Pkg.Type/Pkg.Effect unrepresentable (estate-wide port blocker; ADR-014) #228; would change behaviour for many existing files

Refs

Refs #228 (this is the resolution slice; parser slice was #241)
Refs hyperpolymath/standards#124 (estate proof-debt / language-readiness umbrella)

[github-actions]

🔍 Hypatia Security Scan

Findings: 82 issues detected

Severity	Count
🔴 Critical	4
🟠 High	10
🟡 Medium	68

⚠️ Action Required: Critical security issues found!

View findings

[
  {
    "reason": "Action perpolymath/standards/.github/workflows/governance-reusable.yml@main\n needs attention",
    "type": "unpinned_action",
    "file": "governance.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action ons/checkout@v6\n    needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action land/setup-deno@v2\n    needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in affine-vscode-publish.yml",
    "type": "unknown",
    "file": "affine-vscode-publish.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "unknown",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "unknown",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence