Skip to content

style(lib/dune): apply ocamlformat to silence persistent build red#466

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/lib-dune-ocamlformat-380
May 30, 2026
Merged

style(lib/dune): apply ocamlformat to silence persistent build red#466
hyperpolymath merged 1 commit into
mainfrom
fix/lib-dune-ocamlformat-380

Conversation

@hyperpolymath
Copy link
Copy Markdown
Owner

Summary

  • lib/dune's affine_vscode_adapter_source.ml rule (added in PR feat(codegen): embed affine-vscode adapter at compile time (root-cause fix for #139/#104) #380) has been failing the CI Check formatting step on every run since it landed — main has been red on this for days.
  • Apply ocamlformat's preferred wrapping: blank line before (rule, deps / with-stdout-to / bash split across lines. Diff verbatim matches what the failing run printed.
  • Pure formatting — dune build output for affine_vscode_adapter_source.ml is byte-identical.

Test plan

  • CI build job passes (the Check formatting step is what was red).
  • No other regressions — only lib/dune touched.

🤖 Generated with Claude Code

The `affine_vscode_adapter_source.ml` rule added in PR #380 has been
failing the `Check formatting` step on every CI run since landing.
This patch applies ocamlformat's preferred wrapping (blank line
before `(rule`, `deps` / `with-stdout-to` / `bash` split across
lines) so the rule no longer trips formatter `diff` exit-1.

Pure formatting — no behavioural change. `dune build`-generated
output for `affine_vscode_adapter_source.ml` is byte-identical.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@hyperpolymath hyperpolymath enabled auto-merge (squash) May 30, 2026 15:11
@github-actions
Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 83 issues detected

Severity Count
🔴 Critical 4
🟠 High 11
🟡 Medium 68

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "Action perpolymath/standards/.github/workflows/governance-reusable.yml@main\n needs attention",
    "type": "unpinned_action",
    "file": "governance.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action ons/checkout@v6\n    needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action land/setup-deno@v2\n    needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in affine-vscode-publish.yml",
    "type": "unknown",
    "file": "affine-vscode-publish.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "unknown",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "unknown",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in ci.yml",
    "type": "unknown",
    "file": "ci.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@hyperpolymath hyperpolymath merged commit 4f0f3ca into main May 30, 2026
27 checks passed
@hyperpolymath hyperpolymath deleted the fix/lib-dune-ocamlformat-380 branch May 30, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant