ci: Bump dtolnay/rust-toolchain from efa25f7f19611383d5b0ccf2d1c8914531636bf9 to 3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9#8
Merged
hyperpolymath merged 1 commit intoApr 2, 2026
Conversation
Bumps [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) from efa25f7f19611383d5b0ccf2d1c8914531636bf9 to 3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9. - [Release notes](https://github.com/dtolnay/rust-toolchain/releases) - [Commits](dtolnay/rust-toolchain@efa25f7...3c5f7ea) --- updated-dependencies: - dependency-name: dtolnay/rust-toolchain dependency-version: 3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
dependabot
Bot
deleted the
dependabot/github_actions/dtolnay/rust-toolchain-3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9
branch
Closed
5 tasks
This was referenced May 28, 2026
hyperpolymath
added a commit
that referenced
this pull request
May 31, 2026
…#510) ## Summary Ships the Canvas 2D half of Tier-1 #8 of #446. This is the surface `idaptik-ums` (App.res: 1178 LoC of DOM + canvas) and every non-Pixi UI in the estate has been waiting for; WebGL / WebGL2 / WebGPU stays at `○` until a consumer surfaces a concrete need. ## What lands `stdlib/Canvas.affine` (+170 lines, new module): 1 extern type (`Ctx2D`) + 26 extern fns covering the full idaptik-ums-relevant Canvas 2D surface: | Surface | Externs | |---|---| | Context acquisition | `canvasGetContext2D` | | Styles | `canvasFillStyle` / `StrokeStyle` / `LineWidth` / `GlobalAlpha` | | Rectangles | `canvasFillRect` / `StrokeRect` / `ClearRect` | | Paths | `canvasBeginPath` / `ClosePath` / `MoveTo` / `LineTo` / `Arc` / `Fill` / `Stroke` | | Transform stack | `canvasSave` / `Restore` / `Translate` / `Rotate` / `Scale` | | Text | `canvasFont` / `TextAlign` / `TextBaseline` / `FillText` / `StrokeText` / `MeasureText` | | Images | `canvasDrawImage` / `canvasDrawImageScaled` | `lib/codegen_deno.ml` (+58 lines): 26 `__as_canvas*` prelude helpers + 26 dispatch entries adjacent to the Ipc block. `tests/codegen-deno/canvas_smoke.{affine,harness.mjs}` (+160 lines combined): 5 distinct smoke functions exercise every shipped extern. The `MockCtx2D` records every method call as a typed-op tuple so the test asserts call order + arguments, not just side-effects. The `canvasMeasureText` round-trip exercises the `Json`-return shape (the `TextMetrics`-shaped object). `docs/bindings-roadmap.adoc` row #8 status promoted `○ → ◑`; deferred items captured (WebGL, gradients/patterns, ImageData, curve primitives, compositing/clip). ## Design notes **Why is `HTMLCanvasElement` not its own extern type?** The canvas-creation entry point is host-dependent — browser `document.createElement("canvas")` vs idaptik's pre-existing DOM tree vs jsdom-under-Deno. Treating the canvas as opaque `Json` defers the typed wrapper to the natural follow-up once `affinescript-dom` lands runtime support (currently blocked on the wasm-codegen `for-in` / `while` gap, issue #255). **Why fix `arc` counter-clockwise to `false`?** The 6-arg shape (`ccw` boolean) would force every call site to pass a literal `false`. The 5-arg shape covers the overwhelming majority of consumers; a typed wrapper with the `ccw` flag is a follow-up if a consumer surfaces the need. **Why two separate `drawImage` externs instead of one with optional args?** AffineScript doesn't have JS-style variadic functions; making `w` and `h` `Option<Float>` would force every natural-size call to thread `None`s. The two-extern split keeps each call site simple. **Why open-string `eventMode` / `textAlign` / `textBaseline`?** Same rationale as the PixiJS expansion (#502) — Pixi 8's `eventMode` and Canvas's text-alignment values are open enumerations, and a sum-type binding would either freeze the set or require tagged-variant codegen that doesn't exist on the Deno-ESM backend yet (deferred to json.affine v0.3). Consistency with existing patterns. ## Test plan - [x] `dune build bin/main.exe` — clean (only the expected parser warnings) - [x] `dune runtest --force` — 356 tests pass (was 354 pre-PR; +2 from new Canvas + Ipc modules' AOT smoke) - [x] `tools/run_codegen_deno_tests.sh` — all 19 harnesses including the new `canvas_smoke.harness.mjs` OK - [ ] CI build job - [ ] CI `tools/run_codegen_deno_tests.sh` job - [ ] CI governance + Hypatia (6 baselines per repo CLAUDE.md may be red — pre-existing on main, not regressions) ## Refs - Umbrella: #446 (Tier 1 — idaptik blockers) - Tier-1 sub-issue: #450 - Row updated: `docs/bindings-roadmap.adoc` row #8 - Pattern siblings shipped this session: #502 (PixiJS Container expansion), #506 (Ipc.affine) - Adjacent / future: `affinescript-dom` (gated on #255), WebGL/WebGPU (Tier 3 axis, not surfaced as need yet) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps dtolnay/rust-toolchain from efa25f7f19611383d5b0ccf2d1c8914531636bf9 to 3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9.
Commits
3c5f7eaAdd 1.94.1 patch releaseDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)