revert(cicd_rules): drop duplicate scorecard rule (#390 dup of #403 WF018)#407
Merged
Conversation
#403 WF018) PR #404 added scorecard_wrapper_missing_job_permissions to cicd_rules.ex, but PR #403 had concurrently implemented the same #390 detection as WF018 (check_scorecard_wrapper_missing_job_permissions) in workflow_audit.ex — its canonical home alongside WF019/WF020. This removes the redundant cicd_rules copy (rule, facade delegate, test, changelog entries); WF018 stays as the single implementation. Verified locally (Elixir 1.14): cicd_rules.ex compiles with zero warnings; format-isolation confirms a pure deletion with no pre-existing reformat. https://claude.ai/code/session_01J8oLNn6MjKDRRUF65e2jLf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #404 (merged earlier this session) added
scorecard_wrapper_missing_job_permissionstocicd_rules.exfor #390. But PR #403 had concurrently implemented the same #390 detection asWF018(check_scorecard_wrapper_missing_job_permissions) inworkflow_audit.ex— its canonical home alongsideWF019/WF020. Both landed onmain, so the scorecard-wrapper finding is now detected twice.Per the owner's call, this removes the redundant cicd_rules copy, keeping
WF018as the single implementation.What
Pure deletion of #404's additions:
lib/rules/cicd_rules.ex— thescorecard_wrapper_missing_job_permissionsrule (scan_/check_ fns, module attrs,scorecard_wrapper_path?/1)lib/rules/rules.ex— the facadedefdelegatetest/rules/cicd_rules_scorecard_wrapper_test.exs— deletedCHANGELOG.md/CHANGELOG.adoc— the Add cicd rule: scorecard_wrapper_missing_job_permissions #390 entriesThe
duplicate_cron_schedulerule (#362) and #405's:nodejs_detectedcarve-outs in the same file are untouched.Verified at source (local Elixir 1.14)
elixirconcicd_rules.ex→ 0 warnings / 0 errorsWF018intact inworkflow_audit.ex(#390 is already closed by #403, so no closing keyword here.)
Generated by Claude Code