ci(idris): add fast proof-check gate over all Proofs.idr (#145)#147
Open
hyperpolymath wants to merge 1 commit into
Open
ci(idris): add fast proof-check gate over all Proofs.idr (#145)#147hyperpolymath wants to merge 1 commit into
hyperpolymath wants to merge 1 commit into
Conversation
Adds a dedicated `proof-check` job to idris2-ci.yml that type-checks every src/**/Proofs.idr (glob-discovered) with `idris2 -p contrib -p network --check`, in parallel with the slow full `build`. Closes the gap that let #127's swapped-arg `appendLengthInc` reach main: the full build was too slow to gate (merges outraced it while queued), and the explicit per-module --check list covered ZERO Proofs.idr files — exactly the modules the discharge campaign edits each PR. The job never installs proven and never caches build/, so a stale cache cannot mask a source-level break. Documents the decision as ADR-004; the remaining step (make proof-check a REQUIRED status check via branch protection) is an admin action tracked in #145. Refs #145, #144, #127. https://claude.ai/code/session_01MN5vzRR4MK2dkDNaHqqRDy
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the source-fixable half of #145. Adds a dedicated
proof-checkjob toidris2-ci.ymlthat type-checks everysrc/**/Proofs.idr(glob-discovered, so new proof files are auto-covered) withidris2 -p contrib -p network --check, running in parallel with the slow fullbuild.Why
#127's swapped-arg
appendLengthInc(lengthSnoc arr v— but contriblengthSnocis element-first) failed to type-check and blocked the entireSafeJson.Proofsmodule, yet reachedmain. Two gaps let it through:idris2 --build proven.ipkg(~12-20 min warm) — manual merges routinely outrace it while it sitsqueued.--checklist inidris2-ci.ymlcovered zeroProofs.idrfiles — exactly the modules the Phase-3 discharge campaign edits each PR.What it does
proof-checkjob: globsfind src -name 'Proofs.idr', checks each, emits::error file=…::annotations, fails if any fail.idris2 --install proven.ipkg, never cachesbuild/— so a stale cache cannot mask a source-level break.META.a2ml.Remaining (admin, tracked in #145)
This job is necessary but not sufficient. Closing the gate needs
proof-checkmade a required status check onmainvia branch protection — only the repo admin can toggle that. Until then, "merged" still doesn't imply "CI passed" under the solo-admin-merge posture.Verification
yaml.safe_load→ jobsbuild, proof-check, docs;tomllib→ ADR-001..004).Proofs.idrcheck loop was validated locally on a clean idris2-0.8.0 + contrib install (SafeJson/SafeMath/SafeString proof cones, 0 errors).idris2-ci.yml, which is in the CI path filter — so the newproof-checkjob runs on this PR and proves itself before merge.Refs #145, #144, #127.
Generated by Claude Code