ci(governance): non-blocking drift check for check-ts-allowlist .affine/.deno.js (closes #312)#318
Merged
Merged
Conversation
…ne/.deno.js (closes #312) After #311 swapped the workflow to executing the committed `.deno.js` artifact, the .affine source can silently drift if a maintainer edits it without recompiling. This adds: - `just check-ts-allowlist-drift` recipe — invokes the AffineScript compiler against the .affine source into a temp file and diffs against the committed .deno.js. Exit 0 = in sync. - Non-blocking `continue-on-error: true` CI step in governance-reusable.yml that runs the same diff and surfaces a `::warning::` on drift. Skipped gracefully when the AffineScript compiler isn't on the runner (notice, exit 0). - Pointer comment in check-ts-allowlist.affine header so maintainers see the drift recipe at the obvious place. Non-blocking until the compiler output is hash-pinned per compiler version — the compiler currently stamps a moving "Generated by AffineScript compiler" header. Promotion to blocking is a separate follow-up. Closes #312 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just check-ts-allowlist-driftrecipe — re-compilesscripts/check-ts-allowlist.affineand diffs against committedscripts/check-ts-allowlist.deno.js.continue-on-error: true) CI step ingovernance-reusable.ymlthat runs the same diff and surfaces a::warning::on drift. Skipped gracefully (exit 0) when AffineScript compiler isn't on the runner.check-ts-allowlist.affineheader so maintainers see the drift recipe at the obvious place.Non-blocking until the compiler output is hash-pinned per compiler version (compiler currently stamps a moving "Generated by AffineScript compiler" header). Promotion to blocking is a separate follow-up.
Closes
🤖 Generated with Claude Code