test(manifest,gc): positive postgres-storage case + realistic gc fixture (follow-up to #144)#147
Merged
Conversation
Follow-up to #144 (which closed #112 by dropping the json sidecar store). Adds the two test-only improvements that #144 did not include: - manifest: `postgres_storage_passes_storage_check` — a positive companion to `unsupported_storage_fails`, asserting the postgres dialect passes the new `sidecar-storage-supported` validate check (previously only the negative/json path was covered). - gc: `gc_rejects_non_sqlite_backend` now exercises the realistic non-sqlite value (`postgres`) instead of the dropped `json` value, so the fixture reflects a backend that actually exists post-#112. No production-code change; the sidecar storage set stays closed to sqlite + postgres. https://claude.ai/code/session_01Ux144vBDdySvLUqUrCgkT4
hyperpolymath
pushed a commit
that referenced
this pull request
May 30, 2026
#147 (test-only postgres validate + gc fixture) landed on main after this branch was pushed. Incorporated by keeping #147's postgres-storage validate test and reconciling the gc rejection test with #148's dispatch (postgres gc now reports "not yet implemented"; the json family is supported). https://claude.ai/code/session_01S2xDQQU5o85N3xTpeFUSfN
This was referenced May 30, 2026
hyperpolymath
added a commit
that referenced
this pull request
May 30, 2026
… drop (#149) Wrap-up housekeeping after the V-L2-F2 json-sidecar drop (#112, #144, #147): ADR-0011 documenting why the octad store is relational, a CHANGELOG Removed entry, a README correction, and a Claude Code (web) SessionStart hook + permission allowlist. No production code change. https://claude.ai/code/session_01Ux144vBDdySvLUqUrCgkT4
This was referenced May 30, 2026
🔍 Hypatia Security ScanFindings: 80 issues detected
View findings[
{
"reason": "Action perpolymath/standards/.github/workflows/governance-reusable.yml@main\n needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action actions/checkout@v4 needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action dtolnay/rust-toolchain@stable needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action Swatinem/rust-cache@v2 needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action actions/checkout@v4 needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action dtolnay/rust-toolchain@master needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Action Swatinem/rust-cache@v2 needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in boj-build.yml",
"type": "missing_timeout_minutes",
"file": "boj-build.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in casket-pages.yml",
"type": "missing_timeout_minutes",
"file": "casket-pages.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in casket-pages.yml",
"type": "missing_timeout_minutes",
"file": "casket-pages.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small test-only follow-up to #144 (which closed #112 by dropping the
jsonsidecar store).While #112 was being resolved, two near-identical PRs were prepared concurrently (#144 and #145). #144 landed first and is now on
main; #145 was a duplicate and has been closed. This PR salvages the only two bits #145 had that #144 did not — both test-only, no production-code change:manifest:postgres_storage_passes_storage_check— a positive companion to feat(manifest): drop unimplemented json sidecar store (V-L2-F2, #112) #144'sunsupported_storage_fails. feat(manifest): drop unimplemented json sidecar store (V-L2-F2, #112) #144 covered the rejection path (jsonfails); this asserts thepostgresdialect passes the newsidecar-storage-supportedvalidate check, so both sides of the closed set are covered.gc:gc_rejects_non_sqlite_backendnow uses the realistic non-sqlite valuepostgresinstead of the now-droppedjson, so the fixture reflects a backend that still exists post-V-L2-F2: implement the JSON sidecar storage backend (split from #45) #112.The supported
[sidecar].storageset stays closed tosqlite+postgres.Testing
cargo test— 120 lib + 21 integration/e2e pass.cargo fmt --checkclean;cargo clippy --all-targets -- -D warningsclean.Relates to #112 / #144.
Generated by Claude Code