Skip to content

Add Laravel 13 support#109

Merged
iamfarhad merged 2 commits into
mainfrom
support-laravel-13
May 10, 2026
Merged

Add Laravel 13 support#109
iamfarhad merged 2 commits into
mainfrom
support-laravel-13

Conversation

@iamfarhad
Copy link
Copy Markdown
Owner

@iamfarhad iamfarhad commented May 10, 2026

Summary

  • Add Laravel 13 (^13.0) support for illuminate/support and illuminate/validation
  • Add Orchestra Testbench 11 support for Laravel 13 test runs
  • Extend the CI matrix to test Laravel 13 on supported PHP versions
  • Exclude Laravel 13 from PHP 8.1 and 8.2 because Laravel 13 requires PHP 8.3+

Notes

Laravel 13 requires PHP 8.3+, but the package-level PHP requirement remains ^8.1 so existing Laravel 10-12 users are not blocked. Composer will still enforce PHP 8.3+ when Laravel 13 dependencies are selected.

Testing

  • Not run locally: sandbox could not resolve github.com for cloning the repository.
  • GitHub Actions should validate the expanded matrix on this PR.

Note

Low Risk
Low risk: only widens dependency constraints and CI test matrix; no runtime logic changes, with potential risk limited to version-constraint/resolution issues.

Overview
Adds Laravel 13 compatibility by widening illuminate/support and illuminate/validation constraints to include ^13.0 and updating the package description accordingly.

Expands GitHub Actions CI to test against laravel: 13.*, wiring it to orchestra/testbench: 11.* and excluding unsupported PHP/Laravel combinations (Laravel 13 not run on PHP 8.1/8.2).

Reviewed by Cursor Bugbot for commit 3026bbd. Configure here.

@iamfarhad iamfarhad merged commit b67cb26 into main May 10, 2026
27 checks passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package description and dependency constraints in composer.json to include support for Laravel 13. Feedback indicates that these changes are premature since Laravel 13 has not yet been released, and including these versions will lead to dependency resolution failures for users and CI environments.

Comment thread composer.json
{
"name": "iamfarhad/validation",
"description": "🇮🇷 Complete Laravel Persian validation package - Iranian national ID, mobile numbers, Shamsi dates, IBAN/Sheba, postal codes & more. Modern Laravel 10-12 support with both ValidationRule objects & string-based rules.",
"description": "🇮🇷 Complete Laravel Persian validation package - Iranian national ID, mobile numbers, Shamsi dates, IBAN/Sheba, postal codes & more. Modern Laravel 10-13 support with both ValidationRule objects & string-based rules.",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Claiming support for Laravel 13 is premature. Laravel 12 is the next major version (expected Q1 2025), and Laravel 13 is not expected until 2026. Including it in the description may be misleading as it cannot be verified yet.

Suggested change
"description": "🇮🇷 Complete Laravel Persian validation package - Iranian national ID, mobile numbers, Shamsi dates, IBAN/Sheba, postal codes & more. Modern Laravel 10-13 support with both ValidationRule objects & string-based rules.",
"description": "🇮🇷 Complete Laravel Persian validation package - Iranian national ID, mobile numbers, Shamsi dates, IBAN/Sheba, postal codes & more. Modern Laravel 10-12 support with both ValidationRule objects & string-based rules.",

Comment thread composer.json
Comment on lines +69 to +70
"illuminate/support": "^10.0|^11.0|^12.0|^13.0",
"illuminate/validation": "^10.0|^11.0|^12.0|^13.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding ^13.0 for illuminate dependencies is premature. These versions do not exist yet and cannot be tested. This will cause dependency resolution errors in CI and for users attempting to update, as the author noted that local tests were not run. It is recommended to remove these until the versions are actually available.

Suggested change
"illuminate/support": "^10.0|^11.0|^12.0|^13.0",
"illuminate/validation": "^10.0|^11.0|^12.0|^13.0"
"illuminate/support": "^10.0|^11.0|^12.0",
"illuminate/validation": "^10.0|^11.0|^12.0"

Comment thread composer.json
"require-dev": {
"phpunit/phpunit": "^10.0|^11.0|^12.0",
"orchestra/testbench": "^8.0|^9.0|^10.0",
"orchestra/testbench": "^8.0|^9.0|^10.0|^11.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding ^11.0 for orchestra/testbench is premature as it corresponds to Laravel 13 support, which is not yet available. This will prevent successful dependency resolution.

Suggested change
"orchestra/testbench": "^8.0|^9.0|^10.0|^11.0",
"orchestra/testbench": "^8.0|^9.0|^10.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant