Bugfix/broken tz conversion on dst change#3007
Open
PawelPlutaUek20 wants to merge 3 commits intoiamkun:devfrom
Open
Bugfix/broken tz conversion on dst change#3007PawelPlutaUek20 wants to merge 3 commits intoiamkun:devfrom
PawelPlutaUek20 wants to merge 3 commits intoiamkun:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A brief description of why is this needed:
with keepLocalTime, we add the difference of offsets, but of the offsets before adding the timezone diff.
Example: If we add 17 hours from UTC to Australia/Sydney, but within those 17 hours the time went backwards, the hour would be 16 and not 17. That's why after adding the time, we need to add the dst diff.