Skip to content

Keyboard Task#4

Open
ibrkhalil wants to merge 22 commits intodevelopfrom
keyboard
Open

Keyboard Task#4
ibrkhalil wants to merge 22 commits intodevelopfrom
keyboard

Conversation

@ibrkhalil
Copy link
Copy Markdown
Owner

No description provided.

@ibrkhalil ibrkhalil requested a review from mcherri September 24, 2021 12:42
Copy link
Copy Markdown
Collaborator

@mcherri mcherri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix.

Comment thread components/keyboardScene.brs Outdated
Comment thread components/keyboardScene.brs Outdated
Comment thread components/keyboardScene.brs Outdated
Comment thread components/keyboardScene.xml Outdated
<script type="text/brightscript" uri="keyboardScene.brs" />
<children>
<Group id="mainSearch">
<MiniKeyboard id="keyboard" translation="[150,150]" />
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this harder 😄 please make the keyboard component yourself. Make it look like the video.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, you are in the right direction. The keyboard focus is buggy though.

2021-09-29-123933

  • The focus indicator is not correct.
  • When I selected W, I got ....
  • Is it possible that you make the special characters work? 😎

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I tried numeros ways to fix the focus but it wont be fixed, I'll try again
  • gonna fix the W part
  • definitely possible 😉

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better now.

2021-09-30-112948

  • W is not fixed.
  • The result list are on top of the keyboard.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants