Merged
Conversation
Miniconda tests sometimes failed during the pack build phase. It's a transitive error that is related to Docker that usually does not happen on a second run. The wrapper will retry the build immediately.
That way, if all the retry fails, the developer will have the full picture of failures, not just the last one.
- loop runs retry + 1 time (0 is initial attempt, rest is retry) - Show retry message at the start of the loop starting the first retry round
This matches more precisely with the logic of PackBuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR implements a helper struct that allows to execute and retry a pack build.
This comes from the miniconda tests that sometimes fail with an EOF error on either jammy or noble, sometimes (but rarely) both.
Up until now, restarting the tests was enough to make it pass.
Since this error appears to be Docker specific and is transiant, directly retrying the build after a failure seems to be enough.
Note this has nothing to do with the implementation of the buildpack itself.