Skip to content

Conversation

@lguerard
Copy link
Contributor

No description provided.

@ehrenfeu ehrenfeu self-assigned this Mar 11, 2025
@lguerard
Copy link
Contributor Author

Sorry about the whole mess, let me know if I should rebase and cherry pick only the commits related to bdv for that PR and make others for the other files.

@ehrenfeu
Copy link
Member

I started a new branch last night, cherry 🍒 picking the non BDV commits already.
Could you remove them (as in: git revert the commits) from your devel branch and push again?

@lguerard
Copy link
Contributor Author

All of the commits or only the non BDV ones ?

@ehrenfeu
Copy link
Member

Only the non BDV ones (you can simply check the new branch for identifying them).
Otherwise we could just close this PR.

@ehrenfeu
Copy link
Member

It's the branch with yesterday's name in it. Sorry, seem to be unable to copy the branch name on the Android app... 🫥

@lguerard
Copy link
Contributor Author

Done, hopefully I didn't create a bigger mess..;

@ehrenfeu
Copy link
Member

Looks much cleaner already. Now the tests (or the code?) need to be fixed.

@ehrenfeu ehrenfeu changed the title Update methods to work with latest version of BigStitcher and add fusion using BDV playground Update for latest version BigStitcher, add fusion (BDV-playground) Mar 13, 2025
@ehrenfeu ehrenfeu moved this to In progress in imcflibs Mar 13, 2025
@ehrenfeu ehrenfeu added this to the 1.5.0 milestone Mar 14, 2025
@ehrenfeu ehrenfeu linked an issue Mar 14, 2025 that may be closed by this pull request
@ehrenfeu ehrenfeu added enhancement New feature or request next-release Issues blocking the next release labels Mar 18, 2025
@ehrenfeu ehrenfeu linked an issue Mar 20, 2025 that may be closed by this pull request
@lguerard
Copy link
Contributor Author

The remaining linting error is for stuff outside of BDV.

@ehrenfeu
Copy link
Member

Cool, I guess this is ready for being merged then!

@imcf imcf deleted a comment from codecov bot Mar 25, 2025
@ehrenfeu ehrenfeu merged commit 3601c20 into imcf:devel Mar 25, 2025
3 of 5 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in imcflibs Mar 25, 2025
@imcf imcf deleted a comment from codecov bot Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request next-release Issues blocking the next release

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Review BDV related docstrings

2 participants