Pin default shell to cmd.exe on windows#71
Open
ysl2 wants to merge 3 commits intoimg-paste-devs:masterfrom
Open
Pin default shell to cmd.exe on windows#71ysl2 wants to merge 3 commits intoimg-paste-devs:masterfrom
ysl2 wants to merge 3 commits intoimg-paste-devs:masterfrom
Conversation
|
Since this recurs and has been battle-tested maybe, it's safer to copy from there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have set my default shell to powershell 7 (
let &shell='pwsh'), but the command in functions:SaveFileTMPWin32iscmd.exeformat.So I realized we should backup the original shell first (defined by
&shelland&shellcmdflag, run:h systemfor more information), then run the "powershell paste image" command, finally we should recover the original shell. If we don't change the&shelltocmd.exe, it willreturn 1indicates the command failed.