Fix: Potential Overflow in _totalSupply#259
Open
rickymcalister wants to merge 1 commit intoimmutable:mainfrom
Open
Fix: Potential Overflow in _totalSupply#259rickymcalister wants to merge 1 commit intoimmutable:mainfrom
rickymcalister wants to merge 1 commit intoimmutable:mainfrom
Conversation
… 0.8.0) to avoid any potential overflows and revert the transaction if one occurs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverage Solidity's built-in overflow/underflow checks (Solidity 0.8.0) to avoid any potential overflows and revert the transaction if one occurs.
If an overflow occurs,
_totalSupplywould wrap around to a small value, leading to incorrect accounting of the total supply of tokens.The best way to prevent this is to use Solidity's built-in overflow/underflow checks by using the
+=operator instead of=, Solidity will automatically revert the transaction if an overflow occurs.