Merged
Conversation
ermyas
reviewed
Nov 19, 2025
ermyas
reviewed
Nov 19, 2025
ermyas
reviewed
Nov 19, 2025
ermyas
reviewed
Nov 19, 2025
ermyas
reviewed
Nov 19, 2025
| vm.startBroadcast(); | ||
|
|
||
| // Deploy zone if it doesn't already exist | ||
| if (zoneAddress.code.length == 0) { |
Contributor
There was a problem hiding this comment.
Should this come earlier? given the above code might be a bit moot if this contract is already deployed?
Contributor
Author
There was a problem hiding this comment.
The code above serves as a sanity check to prevent accidental deployment AND accidental skipping deployment (e.g. if the zone code changes but we forget to update the expected address constant).
ermyas
previously approved these changes
Nov 19, 2025
drinkcoffee
reviewed
Nov 19, 2025
drinkcoffee
reviewed
Nov 19, 2025
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
drinkcoffee
approved these changes
Nov 19, 2025
ermyas
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Seaport 1.6 and ImmutableSignedZoneV3 deployment scripts.
Note
Adds scripts and tooling to deploy
ConduitController,ImmutableSeaport, andImmutableSignedZoneV3via CREATE2 with address precheck, plus README and a network-aware deploy wrapper.script/trading/seaport16/DeployConduitController.s.sol: DeploysKEYLESS_CREATE2, Create2 factories, andConduitController(skip-if-exists; raw signed tx usage).script/trading/seaport16/DeployImmutableSeaport.s.sol: DeploysImmutableSeaportviaAccessControlledDeployer+IDeployer(CREATE2), verifies expected address before broadcasting.script/trading/seaport16/DeployImmutableSignedZoneV3.s.sol: DeploysImmutableSignedZoneV3via CREATE2 with precomputed address checks againstImmutableSeaport.script/trading/seaport16/deploy.sh: Network-aware wrapper (mainnet/testnet), dry-run/broadcast, Blockscout verification, Ledger HD path support.script/trading/seaport16/README.md: Usage, required env vars, and deploy targets.Written by Cursor Bugbot for commit 2ec1285. This will update automatically on new commits. Configure here.