Draft
Conversation
jasonzwli
reviewed
Aug 14, 2023
|
|
||
| import { AccessControlEnumerable } from "@openzeppelin/contracts/access/AccessControlEnumerable.sol"; | ||
|
|
||
| abstract contract ERC721AccessControl is AccessControlEnumerable { |
Contributor
There was a problem hiding this comment.
I'm not sure if we want to refer to this as ERC721AccessControl as then it implies in implements ERC721 interfaces. Maybe we should rename it to just ImmutableAccessControl something else?
jasonzwli
reviewed
Aug 14, 2023
| All other ERC721 functions are supported, with routing logic depending on the tokenId. | ||
| */ | ||
|
|
||
| abstract contract ERC721HybridMinting is ERC721PsiBurnable, ERC721 { |
Contributor
There was a problem hiding this comment.
can we have this extend ERC721Royalty instead of ERC721 since ERC721Royalty already extends ERC721?
jasonzwli
reviewed
Aug 14, 2023
|
|
||
| // | ||
| function _safeMint(address to, uint256 quantity) internal virtual override(ERC721, ERC721Psi) { | ||
| return super._safeMint(to, quantity); |
Contributor
There was a problem hiding this comment.
wonder if it makes sense to explicitly override and call ERC721Psi._safeMint(to, quantity) here since thats what is actually being called. Same for the two overrides below
Contributor
|
@alex-connolly this PR appears to be stale, and superseded by newer work. Should this PR be abandoned? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.