fix(audience): build @imtbl/audience in publish workflow#2845
Merged
ImmutableJeffrey merged 1 commit intomainfrom Apr 10, 2026
Merged
fix(audience): build @imtbl/audience in publish workflow#2845ImmutableJeffrey merged 1 commit intomainfrom
ImmutableJeffrey merged 1 commit intomainfrom
Conversation
The publish workflow's build step (`pnpm build`) runs nx with an explicit
project list — `@imtbl/sdk,@imtbl/checkout-widgets`. `@imtbl/audience` was
missing, so its `dist/` was never produced before `pnpm pack-npm-packages`
ran. Because `@imtbl/audience/package.json` declares `"files": ["dist"]`,
`npm pack` then shipped tarballs containing only `package.json` and
`LICENSE.md` — no compiled output.
Symptom on the registry today:
- `@imtbl/audience@0.0.1-alpha.0` and `@imtbl/audience@2.15.0-alpha.21`
both install successfully but contain no `dist/`. Anything trying to
`import { Audience } from '@imtbl/audience'` fails at module resolution
because `package.json#main` points at `dist/node/index.cjs` and the
file doesn't exist.
PR #2843 added `@imtbl/audience` to the version-seeding step, so it gets
version-bumped on every publish — but the build step was never updated
in lockstep. Add it here, and rename the workflow step labels so they
match what's actually being built/packed.
After this lands, the next publish should produce a real tarball. Verify
locally with:
pnpm build
cd packages/audience/sdk && pnpm pack --dry-run
The dry-run output should list files under `dist/node/`, `dist/browser/`,
and `dist/types/`.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit ce0a03d
☁️ Nx Cloud last updated this comment at |
JCSanPedro
approved these changes
Apr 10, 2026
w3njah
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@imtbl/audienceis published to npm but the package is empty — nodist/folder, justpackage.jsonandLICENSE.md. Anything trying to import from it fails at module resolution because the entry point file (dist/node/index.cjs) doesn't exist.Cause
The publish workflow runs
pnpm buildwith an explicit list of packages:@imtbl/audienceisn't in the list, so it's never built before the pack step. The pack step then ships an empty tarball because@imtbl/audience/package.jsononly includesdist/and there's nothing there.Fix
Add
@imtbl/audienceto the build list. Update the workflow step labels so they match what's actually built and packed.Test plan
workflow_dispatchwithdry_run: trueand check the resultingimtbl-audience-*.tgzartifact for files underdist/.dist/node/,dist/browser/, anddist/types/.🤖 Generated with Claude Code