Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR harmonizes systemd service configuration between RPM and Debian packages by adopting a common file structure where user/group configuration is separated from service options.
Changes:
- Split configuration into two files:
metaproxy.user(user/group settings) and a sysconfig-style file (service options) - Updated variable expansion syntax from
$SERVER_USERto${SERVER_USER}in rpm/metaproxy.sysconfig for consistency - Debian now uses the RPM configuration files (
rpm/metaproxy.userandrpm/metaproxy.sysconfig) instead of maintaining separatedebian/metaproxy.default
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rpm/metaproxy.sysconfig | Updated variable expansion syntax from $SERVER_USER to ${SERVER_USER} for consistency |
| debian/rules | Added installation of rpm/metaproxy.user and rpm/metaproxy.sysconfig to appropriate Debian locations |
| debian/metaproxy.service | Added EnvironmentFile directive for /etc/metaproxy/metaproxy.user to load user/group variables |
| debian/metaproxy.postinst | Changed to source /etc/metaproxy/metaproxy.user instead of /etc/default/metaproxy |
| debian/metaproxy.install | Added entries for metaproxy.user and /etc/default/metaproxy to installation manifest |
| debian/metaproxy.default | Removed file - configuration now split between metaproxy.user and sysconfig files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.