Keep a reference to the created task#218
Merged
Merged
Conversation
insolor
reviewed
Jun 16, 2026
insolor
reviewed
Jun 16, 2026
glglgl-de
force-pushed
the
keep-task-reference
branch
from
75a5329 to
fbdcb95
Compare
Owner
|
Another thing, please rename |
The Python documentation states that asyncio only keeps a weak reference to a created task. If the caller doesn't keep it, it might be garbage collected. Thus, keep a reference in a set. Remove that as soon as the task is done. Besides, let the wrapper function return that task for the case that someone wants to access the return value of the wrapped function.
glglgl-de
force-pushed
the
keep-task-reference
branch
from
fbdcb95 to
6698c1f
Compare
insolor
approved these changes
Jun 17, 2026
Owner
|
Thanks for your contribution, much appreciated |
Contributor
Author
|
Thanks for accepting my contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python documentation states that asyncio only keeps a weak reference to a created task. If the caller doesn't keep it, it might be garbage collected.
Thus, keep a reference in a set. Remove that as soon as the task is done.
Besides, let the wrapper function return that task for the case that someone wants to access the return value of the wrapped function.