Derive the sleep time from the Tk settings (2nd attempt)#221
Merged
Conversation
The Tk main loop defines its sleep time via the parameter "getbusywaitinterval". Adjust our waiting time to that value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, it's me again. I found another thing which might be worth improving.
The Tk main loop defines its sleep time via the parameter "getbusywaitinterval".
We could adjust our waiting time to that value (whose default is 20 ms and which can be configured) instead of using 10 ms as a fixed value.
(It turned out that it is a bad idea to push to a closed PR and only then reopen it. Sorry for the mess.)