Skip to content

silence sass deprecation warnings#10

Open
augiethornton wants to merge 1 commit intoinstructure:masterfrom
augiethornton:silence-sass-deprecation-warnings
Open

silence sass deprecation warnings#10
augiethornton wants to merge 1 commit intoinstructure:masterfrom
augiethornton:silence-sass-deprecation-warnings

Conversation

@augiethornton
Copy link
Copy Markdown
Collaborator

 1	## Summary
 2	
 3	Silence known Dart Sass deprecation warnings that are emitted during Canvas asset compilation by adding the `silenceDeprecations` option to the `sass.renderSync()` call in `compileBundle.js`.
 4	
 5	The suppressed deprecations are:
 6	- **import** - Canvas still uses legacy `@import` syntax
 7	- **global-builtin** - Canvas uses global built-in Sass functions
 8	- **color-functions** - Legacy color function usage
 9	- **legacy-js-api** - The legacy JavaScript API for Dart Sass
10	- **if-function** - The `if()` function deprecation
11	
12	These warnings are expected and produce significant noise during compilation since Canvas has not yet migrated away from these legacy patterns. The sass package was upgraded to 1.98.0 in commit c329672, which introduced these deprecation warnings.
13	
14	## Test plan
15	- Run `yarn run compile-sass` and verify deprecation warnings are no longer emitted
16	- Verify compiled CSS output is unchanged
17	

@augiethornton augiethornton force-pushed the silence-sass-deprecation-warnings branch 3 times, most recently from 7725e73 to 40123fb Compare April 2, 2026 20:05
@augiethornton augiethornton marked this pull request as ready for review April 2, 2026 20:06
@augiethornton augiethornton requested a review from maths22 April 2, 2026 20:09
@augiethornton augiethornton force-pushed the silence-sass-deprecation-warnings branch from 40123fb to 80645b5 Compare April 3, 2026 19:40
     2
     3	Add silenceDeprecations option to renderSync() to suppress
     4	known Dart Sass deprecation warnings during compilation.
     5	These warnings are expected since Canvas still uses legacy
     6	@import syntax and global built-in functions.
     7
@augiethornton augiethornton force-pushed the silence-sass-deprecation-warnings branch from 80645b5 to fdeae33 Compare April 3, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant