Skip to content

Conversation

@deiga
Copy link
Contributor

@deiga deiga commented Jan 1, 2026

  • Separate Unit tests to own Test func
  • Add test to ensure that destroy_on_drift and ignore_changes together prevents replacement of externally modified secret

Before the change?

  • No test to verify that destoy_on_drift = false and lifecycle.ignore_changes = [plaintext_value, encryped_value] would not update plan on external changes

After the change?

  • Regression test to ensure that external changes don't force changes on a secret with destoy_on_drift = false and lifecycle.ignore_changes = [plaintext_value, encryped_value]

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

deiga added 2 commits January 1, 2026 23:21
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
…her prevents replacement of externally modified secret

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant