Skip to content

refactor: migrate resource_github_actions_environment_variable to tflog#3325

Closed
texasich wants to merge 3 commits into
integrations:mainfrom
texasich:refactor/tflog-actions-env-variable
Closed

refactor: migrate resource_github_actions_environment_variable to tflog#3325
texasich wants to merge 3 commits into
integrations:mainfrom
texasich:refactor/tflog-actions-env-variable

Conversation

@texasich
Copy link
Copy Markdown

@texasich texasich commented Apr 9, 2026

Replace Go standard log package with HashiCorp structured tflog for consistent logging across the provider.

Changes:


Before the change?

resource_github_actions_environment_variable.go uses Go's standard log.Printf for logging, which produces unstructured output inconsistent with the rest of the provider.

After the change?

Logging uses HashiCorp's tflog.Info with structured key-value fields (variable_id), consistent with the pattern established in other migrated files like resource_github_membership.go.

Pull request checklist

  • Schema migrations have been created if needed
  • - [x] Acceptance tests have been run (no behavioral changes — logging only)
  • - [x] Documentation has been updated if needed (N/A — internal refactor)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Comment thread github/resource_github_actions_environment_variable.go Outdated
@texasich
Copy link
Copy Markdown
Author

texasich commented Apr 9, 2026

Good catch, thanks @deiga! Fixed in 7a882e5 — now using a static message string with the variable ID passed only through the structured fields map. Also removed the now-unused fmt import.

deiga
deiga previously approved these changes Apr 26, 2026
@deiga deiga added vNext Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Apr 26, 2026
@deiga deiga requested a review from robert-crandall April 26, 2026 17:02
@texasich texasich force-pushed the refactor/tflog-actions-env-variable branch from d3fc080 to c369f5b Compare April 26, 2026 17:07
deiga
deiga previously approved these changes Apr 26, 2026
texasich added 2 commits May 5, 2026 20:35
Replace Go standard `log` package with HashiCorp structured `tflog` for consistent logging across the provider.

Changes:
- Replace `log` import with `fmt` and add `tflog` import
- Convert `log.Printf` to `tflog.Info` with structured fields

Part of integrations#3070
Address review feedback: use static log message string instead of
fmt.Sprintf inside tflog.Info. Remove now-unused "fmt" import.
@texasich texasich force-pushed the refactor/tflog-actions-env-variable branch from 07b7a72 to 64772a1 Compare May 6, 2026 01:36
@deiga deiga removed the request for review from robert-crandall May 6, 2026 12:33
@texasich
Copy link
Copy Markdown
Author

Friendly ping — is this still on the radar? Happy to rebase if needed.

@deiga
Copy link
Copy Markdown
Collaborator

deiga commented May 11, 2026

Hey @texasich 👋
Thanks for using a comment without a ping! 🙏

This is on the radar, yes, but we're short on capacity right now and are focusing on some bigger QoL changes before merging anything else

Sorry for the wait 😬

@texasich
Copy link
Copy Markdown
Author

Gentle nudge on this one — been open a while. Happy to rebase if there are conflicts, or make any changes needed. Let me know if anything's blocking review. 🙏

@texasich texasich closed this May 30, 2026
texasich added a commit to texasich/terraform-provider-github that referenced this pull request Jun 5, 2026
Replace Go standard `log` package with HashiCorp structured `tflog` for consistent logging across the provider.

Changes:
- Replace `log` import with tflog import
- Convert `log.Printf` to `tflog.Info` with structured fields

Part of integrations#3070

Closes integrations#3325

Signed-off-by: texasich <101962694+texasich@users.noreply.github.com>
@texasich
Copy link
Copy Markdown
Author

texasich commented Jun 5, 2026

@deiga: per your request to reopen #3325 instead of #3477, I closed #3477 as duplicate. However, GitHub won't let me reopen #3325 via API because the branch was force-pushed after the PR was created (SHA mismatch: PR points to f428207, branch is now at 6c981b9). The PR shows "Closed with unmerged commits" - the fix is ready on the current branch.

Could you reopen #3325 from the UI (maintainer only)? The tflog migration is small, tests pass, and this avoids a fresh PR.

@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Jun 5, 2026

@texasich Oh, sry. Apparently I can't either because of the branch being changed
image

texasich added a commit to texasich/terraform-provider-github that referenced this pull request Jun 5, 2026
Replace Go standard `log` package with HashiCorp structured `tflog` for consistent logging across the provider.

Changes:
- Replace `log` import with tflog import
- Convert `log.Printf` to `tflog.Info` with structured fields

Part of integrations#3070

Closes integrations#3325

Signed-off-by: texasich <101962694+texasich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR vNext

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MAINT] Tracking issue for refactoring logging to use tflog instead of log

2 participants