fix: support repository rename in resource_github_actions_repository_…#3396
Conversation
…oidc_subject_claim_customization_template Related to integrations#3180
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
| return nil | ||
| } | ||
| return diag.FromErr(err) | ||
| } |
There was a problem hiding this comment.
I could use the same wrapper deleteResourceOn404AndSwallow304OtherwiseReturn I guess
…ect_claim_customization_template-repository-rename
|
@deiga @stevehipwell let me know if I can do anything to facilitate the review of this change |
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @acouvreur. Could you add an empty test for the migration so we know what we need to enables when we have a pattern. Also you may want to take a look at #3476 which is the latest migration work I've done and should be the best pattern to follow.
| return diag.FromErr(err) | ||
| } | ||
|
|
||
| return resourceGithubActionsRepositoryOIDCSubjectClaimCustomizationTemplateRead(ctx, d, meta) |
There was a problem hiding this comment.
For modernising resources, removing the call to read is a minimum.
2 participants
…oidc_subject_claim_customization_template
Related to #3180
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!