fix: org detection failure on ghec-dr endpoints#3422
Open
ebk45 wants to merge 5 commits into
Open
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
portellir
approved these changes
May 13, 2026
willjr
approved these changes
May 13, 2026
ebk45
force-pushed
the
fix/ghec-dr-org-detection
branch
from
18e07c4 to
ae00517
Compare
…ection # Conflicts: # github/config_test.go
stevehipwell
added
the
Status: Blocked
Collaborator
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
This PR shouldn't be required as the Get Org API should work correctly for GHEC-DR. Let's see if we can figure out why the API isn't responding correctly before looking for workarounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2626
Before the change?
base_urlis a GHEC-DR endpoint (https://api.*.ghe.com/),Organizations.Get()fails due to incorrect URL construction in thego-githublibrary. The error is silently discarded, leavingIsOrganizationasfalse. Any resource or data source that callscheckOrganization()(e.g.github_external_groups) then fails with the misleading error:this resource can only be used in the context of an organization, "XYZ" is a user.After the change?
Organizations.Get()fails, the provider logs a[WARN]and falls back toUsers.Get()to check the owner'stypefield. Since/users/{owner}works correctly on GHEC-DR endpoints, the organization is detected andIsOrganizationis set totrue. Downstream resources work as expected.Pull request checklist
Does this introduce a breaking change?