fix: skip github_team_members deletion when parent team is already gone

[nitinjain999]

Resolves #3411

---

Before the change?

When github_team and github_team_members are destroyed together, the team deletion removes all members server-side. The subsequent github_team_members destroy makes N individual RemoveTeamMembershipByID API calls that all return 404 and fail loudly.

Additionally, if a team is deleted outside of Terraform, the next terraform plan or terraform refresh would not remove github_team_members from state — it would either error or silently return an empty member list, causing a perpetual diff.

After the change?

Delete: resourceGithubTeamMembersDelete checks for a 404 at both points — the getTeamID/getTeamSlug REST lookup and the RemoveTeamMembershipByID call — and treats either as a no-op, returning cleanly. Destroying github_team + github_team_members together no longer errors.

Read: resourceGithubTeamMembersRead now removes the resource from state when the parent team is gone. It handles two paths:

• getTeamSlug 404 (REST) — team identified by slug or numeric ID that no longer exists
• GraphQL organization.team returning null (detected via DatabaseId == 0) — team gone after slug resolution succeeded

An acceptance test is added that deletes the team out-of-band via PreConfig, then runs Destroy: true to exercise the delete path.

Pull request checklist

• Schema migrations have been created if needed — not applicable, no schema changes
• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed — no doc changes needed, no schema or user-visible behaviour change

Does this introduce a breaking change?

• Yes
• No

---

[github-actions]

👋 Hi, and thank you for this contribution!

This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can.

You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions.

---

_{🤖 This is an automated message.}

[nitinjain999]

Tested against a real GitHub org (nitin-sv) using make testacc T=TestAccGithubTeamMembers.

The new subtest succeeds_when_parent_team_is_deleted_out-of-band_before_destroy passes — team deleted via API before destroy, Terraform completes cleanly with no 404 error.

The existing creates_a_team_&_members_configured_with_defaults subtest fails in this environment because the test user is an org owner, and GitHub silently promotes owners to maintainer regardless of the requested role. This is a pre-existing issue unrelated to this change and documented in the provider notes.

[Copilot]

Pull request overview

These provider review instructions are being used.

This PR improves the github_team_members resource’s behavior when its parent GitHub team has been deleted (either by Terraform ordering during destroy or out-of-band), by treating “team not found” as a graceful no-op in Delete and removing the resource from state in Read to avoid perpetual diffs.

Changes:

• Update resourceGithubTeamMembersRead to remove github_team_members from state when the parent team no longer exists (REST 404 during slug lookup, or GraphQL organization.team resolving to null).
• Update resourceGithubTeamMembersDelete to treat “team not found” as a successful no-op and avoid failing on 404s.
• Add an acceptance test that deletes the team out-of-band before running destroy.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
github/resource_github_team_members.go	Adds 404-aware Read/Delete behavior to gracefully handle missing parent teams and prevent drift/perpetual diffs.
github/resource_github_team_members_test.go	Adds an acceptance test scenario for out-of-band team deletion prior to destroy.

[nitinjain999]

Addressed both Copilot review comments:

Delete logic (line 297): On a 404 from RemoveTeamMembershipByID, the code now calls GetTeamByID to distinguish between "team is gone" and "just this membership was removed out-of-band". If the team is gone it short-circuits; if the team still exists it skips that one user and continues the loop.

Test coverage (line 102): Added a RefreshState: true step that deletes the team out-of-band via PreConfig, then asserts the refresh removes github_team_members from state cleanly — covering both the getTeamSlug 404 and DatabaseId==0 guard paths in Read. Verified passing locally against nitin-sv.