-
Notifications
You must be signed in to change notification settings - Fork 803
[SYCL][L0 v2] Fix bindless array image subregion copies #20952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mateuszpn
wants to merge
3
commits into
intel:sycl
Choose a base branch
from
mateuszpn:subregion-tests
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c2a346 to
186e439
Compare
186e439 to
89881bd
Compare
…dation + UR region mapping)
89881bd to
17d7288
Compare
9932f88 to
f0f42ea
Compare
f0f42ea to
8581964
Compare
pbalcer
reviewed
Jan 7, 2026
| } else if (ZeImageDesc.type == ZE_IMAGE_TYPE_2D || | ||
| ZeImageDesc.type == ZE_IMAGE_TYPE_2DARRAY) { | ||
| Region->depth = 1; | ||
| // Runtime validation of Origin values based on image type |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to admit, I'm not super well versed in image support in L0. Can you describe what the change is, and why it fixes the problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bindless array image subregion copies on Level Zero v2 (SYCL validation + UR region mapping)
Enable tests (previously failing and disabled with no tracking):
bindless_images/array/read_write_1d_subregion.cpp
bindless_images/array/read_write_2d_subregion.cpp