[SYCL] Add in-source versioning for DPCPP compiler by elizabethandrews · Pull Request #21570 · intel/llvm

elizabethandrews · 2026-03-19T14:43:51Z

DPC++ Version Information is now stored in compiler source. clang --version will continue to display build information when local CI is used (i.e. SYCL_BUILD_INFO is defined), but will display in-source version otherwise.

cmake/Modules/DPCPPVersion.cmake should be updated to hold version information for each release.

Example Output:

DPC++ compiler 6.3.0 build based on:
clang version 23.0.0git (https://github.com/intel/llvm.git 5947c2aff087f88c90dcd56857405270ff0d4010)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: */releasebuild/bin
Build config: +assertion

Fixes: #21510

cmake/Modules/DPCPPVersion.cmake should be updated to hold version information for each release.

elizabethandrews · 2026-03-19T14:46:25Z

@tahonermann I am unable to add you as a reviewer for some reason

mdtoguchi

OK for driver

YuriPlyakhin

llvm/CMakeLists.txt change LGTM

elizabethandrews · 2026-03-20T20:00:40Z

I think I have addressed all review comments. The latest commit adds a pre-release indicator. The commit also changes the --version output with SYCL_BUILD_INFO to include version information

premanandrao · 2026-03-20T21:26:48Z

DPC++ Version Information is now stored in compiler source. clang --version will continue to display build information when local CI is used (i.e. SYCL_BUILD_INFO is defined), but will display in-source version otherwise.

cmake/Modules/DPCPPVersion.cmake should be updated to hold version information for each release.

Example Output:
DPC++ compiler 6.3.0 build based on:
clang version 23.0.0git (https://github.com/intel/llvm.git 5947c2aff087f88c90dcd56857405270ff0d4010)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: */releasebuild/bin
Build config: +assertion
Fixes: #21510 JIRA: 74112

Please remove Jira info from the description.

premanandrao

Looks okay to me.

tahonermann

This looks good to me. I added two comments that you can ignore or address in whatever way you feel is best. I don't need to review again.

dvrogozh

LGTM

elizabethandrews · 2026-03-20T23:11:03Z

DPC++ Version Information is now stored in compiler source. clang --version will continue to display build information when local CI is used (i.e. SYCL_BUILD_INFO is defined), but will display in-source version otherwise.
cmake/Modules/DPCPPVersion.cmake should be updated to hold version information for each release.
Example Output:
DPC++ compiler 6.3.0 build based on:
clang version 23.0.0git (https://github.com/intel/llvm.git 5947c2aff087f88c90dcd56857405270ff0d4010)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: */releasebuild/bin
Build config: +assertion
Fixes: #21510 JIRA: 74112
Please remove Jira info from the description.

@premanandrao the current guidelines allow us to mention the JIRA number without the link. I think it is useful to have this information in the log.

elizabethandrews · 2026-03-20T23:14:29Z

DPC++ Version Information is now stored in compiler source. clang --version will continue to display build information when local CI is used (i.e. SYCL_BUILD_INFO is defined), but will display in-source version otherwise.
cmake/Modules/DPCPPVersion.cmake should be updated to hold version information for each release.
Example Output:
DPC++ compiler 6.3.0 build based on:
clang version 23.0.0git (https://github.com/intel/llvm.git 5947c2aff087f88c90dcd56857405270ff0d4010)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: */releasebuild/bin
Build config: +assertion
Fixes: #21510 JIRA: 74112
Please remove Jira info from the description.
@premanandrao the current guidelines allow us to mention the JIRA number without the link. I think it is useful to have this information in the log.

I am not 100% certain though. I heard this in a call this week but I didn't verify with someone else. So I will remove it to be safe. Can someone else in this review weigh in just so I know.

tahonermann · 2026-03-23T10:00:53Z

I am not 100% certain though. I heard this in a call this week but I didn't verify with someone else. So I will remove it to be safe. Can someone else in this review weigh in just so I know.

I don't know what the policy is for intel/llvm, but upstream LLVM policy was changed a while ago to explicitly allow mention of private metadata in commit messages (https://llvm.org/docs/DeveloperPolicy.html#commit-messages).

sarnex · 2026-03-23T14:33:50Z

Merging based on request from @elizabethandrews

Adds DPC++ compiler self-identification macros to differentiate intel/llvm compiler from upstream Clang and enable version detection for intel/llvm releases. Fixes:#21509 Depends on: #21570

DPC++ Version Information is now stored in compiler source. clang --version will continue to display build information when local CI is used (i.e. SYCL_BUILD_INFO is defined), but will display in-source version otherwise. cmake/Modules/DPCPPVersion.cmake should be updated to hold version information for each release. Example Output: ``` DPC++ compiler 6.3.0 build based on: clang version 23.0.0git (https://github.com/intel/llvm.git 5947c2a) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: */releasebuild/bin Build config: +assertion ``` Fixes: intel#21510

Adds DPC++ compiler self-identification macros to differentiate intel/llvm compiler from upstream Clang and enable version detection for intel/llvm releases. Fixes:intel#21509 Depends on: intel#21570

Cherry-pick patches adding version macros: #21570 #21572 #21610 #21702 And also remove some info from the workflow file, since it's placed in the source code now. --------- Co-authored-by: elizabethandrews <elizabeth.andrews@intel.com> Co-authored-by: ykhatav <yashasvi.khatavkar@intel.com>

DPC++ Version Information is now stored in compiler source. clang --version will continue to display build information when local CI is used (i.e. SYCL_BUILD_INFO is defined), but will display in-source version otherwise. cmake/Modules/DPCPPVersion.cmake should be updated to hold version information for each release. Example Output: ``` DPC++ compiler 6.3.0 build based on: clang version 23.0.0git (https://github.com/intel/llvm.git 5947c2a) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: */releasebuild/bin Build config: +assertion ``` Fixes: #21510

Adds DPC++ compiler self-identification macros to differentiate intel/llvm compiler from upstream Clang and enable version detection for intel/llvm releases. Fixes:#21509 Depends on: #21570

[SYCL] Add in-source versioning for DPCPP compiler

7aaecd1

cmake/Modules/DPCPPVersion.cmake should be updated to hold version information for each release.

elizabethandrews requested review from a team and bader as code owners March 19, 2026 14:43

elizabethandrews requested a review from KornevNikita March 19, 2026 14:44

dvrogozh reviewed Mar 19, 2026

View reviewed changes

Comment thread cmake/Modules/DPCPPVersion.cmake

ykhatav mentioned this pull request Mar 19, 2026

[SYCL] Add Self macro versioning #21572

Merged

tahonermann reviewed Mar 19, 2026

View reviewed changes

Comment thread clang/lib/Basic/Version.cpp

mdtoguchi approved these changes Mar 19, 2026

View reviewed changes

YuriPlyakhin approved these changes Mar 19, 2026

View reviewed changes

Apply review comments

497dc45

premanandrao approved these changes Mar 20, 2026

View reviewed changes

tahonermann approved these changes Mar 20, 2026

View reviewed changes

Comment thread clang/lib/Basic/Version.cpp

Comment thread cmake/Modules/DPCPPVersion.cmake Outdated

dvrogozh approved these changes Mar 20, 2026

View reviewed changes

Remove extra space

7e1e785

sarnex merged commit 4b59d98 into intel:sycl Mar 23, 2026
31 checks passed

KornevNikita mentioned this pull request Apr 8, 2026

[sycl-rel-7_0] Cherry-pick version-related patches #21703

Merged

Conversation

elizabethandrews commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elizabethandrews commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdtoguchi left a comment

Choose a reason for hiding this comment

Uh oh!

YuriPlyakhin left a comment

Choose a reason for hiding this comment

Uh oh!

elizabethandrews commented Mar 20, 2026

Uh oh!

premanandrao commented Mar 20, 2026

Uh oh!

premanandrao left a comment

Choose a reason for hiding this comment

Uh oh!

tahonermann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dvrogozh left a comment

Choose a reason for hiding this comment

Uh oh!

elizabethandrews commented Mar 20, 2026

Uh oh!

elizabethandrews commented Mar 20, 2026

Uh oh!

tahonermann commented Mar 23, 2026

Uh oh!

sarnex commented Mar 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

elizabethandrews commented Mar 19, 2026 •

edited

Loading

elizabethandrews commented Mar 19, 2026 •

edited

Loading