Skip to content

[SYCL][NewOffloadModel][E2E] adjust separate_compile.cpp test to SeparateCompile/test.cpp#21980

Merged
uditagarwal97 merged 2 commits into
syclfrom
maksimsab-adjust-test
May 13, 2026
Merged

[SYCL][NewOffloadModel][E2E] adjust separate_compile.cpp test to SeparateCompile/test.cpp#21980
uditagarwal97 merged 2 commits into
syclfrom
maksimsab-adjust-test

Conversation

@maksimsab
Copy link
Copy Markdown
Contributor

These 2 tests are related. However, the one for NewOffloadModel lost -Wno-unused-command-line-argument flag leading to compilation error in Windows environment.

fixes: CMPLRLLVM-74117

…rateCompile/test.cpp

These tests are related. However, the one for NewOffloadModel skipped `-Wno-unused-command-line-argument` flag leading to compilation error in windows environment.
@maksimsab maksimsab added the new-offload-model Enables testing with NewOffloadModel. label May 11, 2026
retrigger testing
@maksimsab maksimsab marked this pull request as ready for review May 12, 2026 15:54
@maksimsab maksimsab requested a review from a team as a code owner May 12, 2026 15:54
Copy link
Copy Markdown
Contributor

@hchilama hchilama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me to silence the expected-but-noisy warnings to fix Windows test failures

Copy link
Copy Markdown
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maksimsab
Copy link
Copy Markdown
Contributor Author

@intel/llvm-gatekeepers Could we please merge that? Test failures aren't related.

@uditagarwal97 uditagarwal97 merged commit a8fdc4b into sycl May 13, 2026
35 of 37 checks passed
@uditagarwal97 uditagarwal97 deleted the maksimsab-adjust-test branch May 13, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-offload-model Enables testing with NewOffloadModel.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants