Skip to content

[UR] Static OpenCL adapter#21983

Draft
mateuszpn wants to merge 2 commits into
intel:syclfrom
mateuszpn:ocl-static-link
Draft

[UR] Static OpenCL adapter#21983
mateuszpn wants to merge 2 commits into
intel:syclfrom
mateuszpn:ocl-static-link

Conversation

@mateuszpn
Copy link
Copy Markdown
Contributor

No description provided.

@mateuszpn mateuszpn force-pushed the ocl-static-link branch 5 times, most recently from 61e281d to 2857569 Compare May 12, 2026 12:08
@mateuszpn mateuszpn requested a review from kswiecicki May 12, 2026 13:12
}
#endif
#ifdef UR_STATIC_ADAPTER_OPENCL
if (!adapter_registry.adaptersForceLoaded()) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't duplicate this if.

@@ -0,0 +1,120 @@
// OpenCL function definitions for dynamic loading
// Format: OCL_FUNC(name, required)
// where 'required' is 1 for OpenCL 1.0 functions that must be present, 0 for optional
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you determine which functions are required, and which are not?
some of these don't look right to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants