Increment Minitest assertion count in assert_schema_conform methods#473
Merged
geemus merged 2 commits intointeragent:masterfrom Apr 12, 2026
Merged
Conversation
assert_request_schema_confirm and assert_response_schema_confirm did not call Minitest's assert, so they were not counted as assertions. This caused Minitest to emit "Test is missing assertions" warnings when these were the only assertions in a test. Call `assert true` after successful validation to increment the assertion counter. The call is guarded by `respond_to?(:assertions)` so it is a no-op in non-Minitest environments (e.g. RSpec). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Explain why increment_assertion_count exists so future readers understand the Minitest assertion counting nuance. - Add tests that verify assert_request_schema_confirm and assert_response_schema_confirm each bump the Minitest assertion count on success, guarding against regression. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
@ursm - released in v5.6.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert_request_schema_confirmandassert_response_schema_confirmdid not call Minitest'sassert, so they were not counted as assertions. This caused Minitest to emit "Test is missing assertions" warnings when these were the only assertions in a test.assert trueafter successful validation to increment the assertion counter, guarded byrespond_to?(:assertions)so it is a no-op in non-Minitest environments (e.g. RSpec).Test plan
test/test/methods_test.rb,test/test/methods_new_version_test.rb)🤖 Generated with Claude Code