feat: Automatically approve blocked deposits#2198
Merged
Merged
Conversation
github-actions
Bot
added
package: wallet/backend
dragosp1011
reviewed
May 25, 2026
dragosp1011
reviewed
May 25, 2026
dragosp1011
reviewed
May 25, 2026
dragosp1011
reviewed
May 25, 2026
dragosp1011
reviewed
May 25, 2026
* fix(wallet): enforce subject and access ownership checks for grants * fix(wallet): PR review improvement
* refactor: support for mockgatehub in local environment * fix: fixed linting issues * fix: clean up * fix: repaired broken test related to emailService * fix: removed the +4 precision guard we don't need * fix: address PR review feedback and fix Docker build * fix: removed changes to formatAmount * refactor(local): breaking up into multiple service files * ci: changed configuration scheme to fail fast if misconfigured * ci: makefile target for rafiki assets * ci: default rafiki seeder will only seed two currencies for now * fix: resolved dependency issues and aligned with workspace * refactor: ci now part of local * ci: removal of makefiles * docs: updated readme * lint: fixed all linting problems * fix: cleanup of debug * test: wallet unittest configuration fixes * style: prettier automatic fixes to resolve linting * fix: better secure domain handling * wip: experimenting * refactor: wallet and boutique now run on host * fix: examples are now useful * ci: added npm run to make testing easy * style: linting issues in rafiki setup file * docs: cleanup instructions * style: fixed linting issues introduced when I added th elogging * fix: added validation rules to boutique config * style: fixed linting * style: prettier * fix: removed hardcoded interledger.cards * fix: update dev start * fix: flaky tests resolution * fix: backends will not fail silently * fix: correcting secrets * fix: resolved issue where hosted balances were incorrectly calculated * ci: will now pull before up * fix: we will not ask for sudo if we don't need it anymore * style: prettier lint fix * test: resolved test issue where faker was creating short strings * docs: github copilot instructions update * docs: tweaks to readme * style: prettier fix * fix: removed dangling e2e workspace * fix: minor edit to prevent 'cannot update RefundProvider' bug * fix: solve rafiki connection issues * fix: rafiki assets creation script should fail fast on error * docs: cleaned up documentation and examples * fix: upgraded local environment to use Traefik v3.6 * style: prettier linting * style: did pnpm format * fix(local): traefik will now auth.interledger.test/graphql --------- Co-authored-by: dragosp1011 <dragosh1011@gmail.com> Co-authored-by: Andrei Mihai <andreimihai@Andreis-MacBook-Pro.local>
MihaiAndrei98
force-pushed
the
andrei/int1-632
branch
from
f14f834 to
cb62ecb
Compare
dragosp1011
reviewed
Jun 11, 2026
dragosp1011
reviewed
Jun 11, 2026
dragosp1011
reviewed
Jun 11, 2026
dragosp1011
reviewed
Jun 11, 2026
dragosp1011
previously approved these changes
Jun 12, 2026
Tymmmy
reviewed
Jun 12, 2026
| return account | ||
| } | ||
|
|
||
| public async checkGatehubWalletIds( |
Contributor
There was a problem hiding this comment.
Suggested change
| public async checkGatehubWalletIds( | |
| public async checkGateHubWalletIds( |
| const recevivingWalletAddresses = transactions.map( | ||
| (trx) => trx.receiving_wallet.address | ||
| ) | ||
| const walletIds = await this.accountService.checkGatehubWalletIds( |
Contributor
There was a problem hiding this comment.
Suggested change
| const walletIds = await this.accountService.checkGatehubWalletIds( | |
| const walletIds = await this.accountService.checkGateHubWalletIds( |
Tymmmy
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changes
Got list of pending manual approval transactions from GateHub
Automatically approved above transactions.