Skip to content

ci: use uv.lock when running tests#9214

Open
keturn wants to merge 2 commits into
invoke-ai:mainfrom
keturn:ci-uv-lock
Open

ci: use uv.lock when running tests#9214
keturn wants to merge 2 commits into
invoke-ai:mainfrom
keturn:ci-uv-lock

Conversation

@keturn
Copy link
Copy Markdown
Contributor

@keturn keturn commented May 19, 2026

Summary

Given we run a "uv lock checks" workflow, I assume that means we intend uv.lock to be used.

The uv pip interface is a different thing than the rest of uv (sync, run, etc), it doesn't use uv.lock (but can use version constraints expressed in other ways). Use uv sync instead.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • ❗Changes to a redux slice have a corresponding migration
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions Bot added the CI-CD Continuous integration / Continuous delivery label May 19, 2026
@keturn
Copy link
Copy Markdown
Contributor Author

keturn commented May 19, 2026

All Checks Have Passed
python tests / py3.11: linux-cpu (pull_request) Successful in 31s

This is misleading because this doesn't change a python file, so it didn't actually run the python tests.

@lstein lstein added the 6.13.5 Library Updates label May 22, 2026
@lstein lstein moved this to 6.13.5 LIBRARY UPDATES in Invoke - Community Roadmap May 22, 2026
Copy link
Copy Markdown
Collaborator

@JPPhoto JPPhoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @keturn Any reason we don't use --frozen?

@keturn
Copy link
Copy Markdown
Contributor Author

keturn commented May 27, 2026

Any reason we don't use --frozen?

--locked and --frozen are similar in that neither will change the lockfile, but --locked exits with an error if there was some change in dependencies that hasn't been reflected in the lockfile yet.

I figured --locked was more appropriate for CI, though one could argue it's redundant with the "uv lock checks" workflow and it only needs to be done in one of those places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.13.5 Library Updates CI-CD Continuous integration / Continuous delivery

Projects

Status: 6.13.5 LIBRARY UPDATES

Development

Successfully merging this pull request may close these issues.

4 participants