Fix(model install): wait for startup restore before imports#9239
Open
JPPhoto wants to merge 1 commit into
Open
Fix(model install): wait for startup restore before imports#9239JPPhoto wants to merge 1 commit into
JPPhoto wants to merge 1 commit into
Conversation
github-actions
Bot
added
python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a model install startup race where a new import could be enqueued before incomplete installs had finished restoring.
The model install service now tracks the startup restore thread with an event and waits for restore completion before accepting new imports or reporting install completion. This prevents duplicate or conflicting install work during app startup.
Updated:
invokeai/app/services/model_install/model_install_default.pytests/app/services/model_install/test_model_install.pyRelated Issues / Discussions
QA Instructions
Run
pytest tests/app/services/model_install/test_model_install.pyas well as all other tests.The new test verifies that
import_model()blocks while startup restore is still running, then proceeds after restore completes.Merge Plan
No special merge handling required.
Checklist
What's Newcopy (if doing a release after this PR)