Skip to content

github workflows#66

Merged
iohub merged 1 commit into
mainfrom
dev-vscode
Jun 7, 2026
Merged

github workflows#66
iohub merged 1 commit into
mainfrom
dev-vscode

Conversation

@iohub
Copy link
Copy Markdown
Owner

@iohub iohub commented Jun 7, 2026

Summary by Sourcery

Build:

  • Extend GitHub release workflow matrix with platform-specific fzf and ripgrep download URLs and add steps to fetch, extract, and include these binaries in the dist/bin directory during release builds.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 7, 2026

Reviewer's Guide

Extends the release GitHub Actions workflow to download platform-specific fzf and ripgrep binaries for each build matrix target, embed them alongside the Rust-built codeactor-codebase binary, and ensure they are executable and verified in dist/bin.

File-Level Changes

Change Details Files
Embed platform-specific fzf and ripgrep binaries into release artifacts for each build matrix target.
  • Add fzf_url and rg_url parameters to each matrix target (darwin amd64/arm64 and linux amd64) pointing to specific release tarballs.
  • Harden the "Prepare embedded binaries" script with strict shell options and directory setup for dist/bin.
  • Download, extract, and move the fzf binary from its tarball into dist/bin/fzf.
  • Download, extract, locate (via find), and move the rg binary from its tarball into dist/bin/rg, handling nested directories.
  • Set executable permissions on codeactor-codebase, fzf, and rg, and list dist/bin to verify contents.
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@iohub iohub merged commit 8036296 into main Jun 7, 2026
5 checks passed
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The matrix configuration now duplicates full fzf/rg URLs (including versions) for each target; consider extracting shared version variables or base URLs to reduce duplication and make future upgrades less error-prone.
  • When extracting rg, you can simplify and make the script more predictable by using tar -xzf ... --strip-components to drop the leading directory instead of find + mv, which currently may behave unexpectedly if multiple rg files are present.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The matrix configuration now duplicates full fzf/rg URLs (including versions) for each target; consider extracting shared version variables or base URLs to reduce duplication and make future upgrades less error-prone.
- When extracting rg, you can simplify and make the script more predictable by using `tar -xzf ... --strip-components` to drop the leading directory instead of `find` + `mv`, which currently may behave unexpectedly if multiple `rg` files are present.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant