fix(cookies): only send expires param on web if valid date #8330
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS-pedrogustavobilro
approved these changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
I'm still seeing this warning when running the PWA, don't know if you're getting it as well, and don't think it's related to setCookies, because I get this when opening the cookies page of the test app in PWA, maybe it's the date time component of the ionic framework or how we're using it?
[Ionic Warning]: Unable to parse date string: . Please provide a valid ISO 8601 datetime string.
theproducer
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with
CapacitorCookies.setCookie()on web / PWA where cookies were not being set properly if the expires date was empty or improperly formatted