fix(cli): cap run fails with renamed outputs for android#8334
Open
HASH-0021 wants to merge 1 commit intoionic-team:mainfrom
Open
fix(cli): cap run fails with renamed outputs for android#8334HASH-0021 wants to merge 1 commit intoionic-team:mainfrom
cap run fails with renamed outputs for android#8334HASH-0021 wants to merge 1 commit intoionic-team:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes made in this PR are according to the solution provided in the issue #8040. (This PR closes this issue)
The changes are made to
parseApkNameFromFlavorfunction definition present in cli/src/common.ts file. And also in locations where this function is called (like in cli/src/config.ts and cli/src/android/run.ts files) to change the function call structure. I tried to use only the existing library methods.The new changes work only in the following scenarios. If any of the following scenarios fail, then the code falls back to previous version of
parseApkNameFromFlavorfunction definition.I have tested this changed version on a scaffolded new project. My tests are: