docs(angular): adding overlays documentation with explanation of 8.8's new custom injector functionality #4372
+203
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…s new custom injector functionality
thetaPC
requested changes
Jan 7, 2026
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
Minor changes, the consistency with the sidebar is my main request.
| @@ -0,0 +1,201 @@ | |||
| --- | |||
| title: Overlay Components | |||
| sidebar_label: Overlay Components | |||
Contributor
There was a problem hiding this comment.
Let's stay consistent with React Overlays sidebar title and just call it "Overlays".
Suggested change
| sidebar_label: Overlay Components |
Contributor
There was a problem hiding this comment.
Should we also include a "Docs for Overlays in Ionic" section like the React Overlays page?
Comment on lines
+194
to
+195
| - `AngularModalOptions` - Extends `ModalOptions` with the `injector` property | ||
| - `AngularPopoverOptions` - Extends `PopoverOptions` with the `injector` property |
Contributor
There was a problem hiding this comment.
These might change based on the Ionic Framework PR discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v8.8, we'll add custom injectors to Angular modals and popovers. This documentation is in preparation for that support.