-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(spinner): add recipe and tokens #31014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thetaPC
wants to merge
18
commits into
ionic-modular
Choose a base branch
from
FW-6860
base: ionic-modular
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0a3f41d
feat(spinner): add recipe and tokens
thetaPC 5eee3a8
chore(spinner): run build
thetaPC 75a325a
test(color): update test page and snapshots
thetaPC 53d06e1
chore(spinner): delete old styles
thetaPC 78cfbba
test(spinner): update resize
thetaPC edb0414
test(spinner): remove diff term
thetaPC 2ffac3e
test(spinner): update spacing
thetaPC 3d89f21
feat(spinner): add recipe and config types
thetaPC 363cddf
feat(spinner): change class names
thetaPC 7b13706
test(spinner): update class
thetaPC b2a301a
refactor(spinner): remove plural type
thetaPC 5f0020c
test(spinner): update color snapshots
thetaPC 1179d40
refactor(theme): alphabetize imports
thetaPC 4f5ee31
docs(spinner, chip): update get value functions comments
thetaPC 2cd0043
Merge branch 'FW-6860' of github.com:ionic-team/ionic-framework into …
thetaPC 4c1c6d2
feat(spinner): change type names
thetaPC ee53528
refactor(spinner): change existing config type name
thetaPC 8019941
docs(chip, spinner): update method descriptions
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| export interface SpinnerTemplates { | ||
| [spinnerName: string]: SpinnerTemplate; | ||
| } | ||
|
|
||
| export interface SpinnerTemplate { | ||
| dur: number; | ||
| circles?: number; | ||
| lines?: number; | ||
| elmDuration?: boolean; | ||
| fn: (dur: number, index: number, total: number) => SpinnerData; | ||
| } | ||
|
|
||
| interface SpinnerData { | ||
brandyscarney marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| r?: number; | ||
| y1?: number; | ||
| y2?: number; | ||
| cx?: number; | ||
| cy?: number; | ||
| style: { [key: string]: string | undefined }; | ||
| viewBox?: string; | ||
| transform?: string; | ||
| } | ||
|
|
||
| export type IonSpinnerRecipe = { | ||
| color?: string; | ||
|
|
||
| lines?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
|
|
||
| small?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
| }; | ||
|
|
||
| sharp?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
|
|
||
| small?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| circular?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
| }; | ||
|
|
||
| crescent?: { | ||
| stroke?: { | ||
| width?: string; | ||
| }; | ||
| }; | ||
|
|
||
| // Sizes | ||
| size?: { | ||
| [K in SpinnerSize]?: IonSpinnerSizeDefinition; | ||
| }; | ||
| }; | ||
|
|
||
| type IonSpinnerSizeDefinition = { | ||
| width?: string; | ||
| height?: string; | ||
| }; | ||
|
|
||
| export type IonSpinnerConfig = { | ||
| size?: SpinnerSize; | ||
| }; | ||
|
|
||
| export type SpinnerSize = 'xsmall' | 'small' | 'medium' | 'large' | 'xlarge'; | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says:
But we still have this variable, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we discussed that it would be revisited as we add more components. Should I just remove them?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I thought that was just about the focus variables. I don't see a reason they can't override the
--coloron components directly? Developers might want it to be different than the global theme.