Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves resolves internal
What is the current behavior?
In the dark palette, focused
ion-tab-buttonelements do not receive theion-focusedclass, so the focus indicator is never shown.The
--ion-tab-bar-background-focusedtoken was also not set, causing the focused state to fall back toget-color-shade(#fff) (#e0e0e0)— a light grey that is invisible on a dark background.What is the new behavior?
--ion-tab-bar-background-focusedis defined in the dark palette:#0b0b0bfor iOS and#1b1b1bfor MD, providing a subtle dark-appropriate focus indicator.ion-tab-buttonreceives theion-focusedclass and does not render with the light-mode fallback color in the dark palette.Does this introduce a breaking change?
Other information
The test triggers keyboard mode (required by
focus-visible.ts) before focusing the inner<a>element inside the tab button's shadow DOM, since calling.focus()on the host element is a no-op withoutdelegatesFocus.