Skip to content

fix(modal): prevent double safe-area in fullscreen modals with ion-content (#31015) #31051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vitalcheffe wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

fix(modal): prevent double safe-area in fullscreen modals with ion-content (#31015) #31051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions core/src/components/modal/modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1522,10 +1522,13 @@ export class Modal implements ComponentInterface, OverlayInterface {
}
}

// Only apply wrapper padding for standard Ionic layouts (has ion-content
// but no ion-footer). Custom modals with raw HTML are fully
// developer-controlled and should not be modified.
if (!hasContent || hasFooter) return;
// Only apply wrapper padding when ion-content is absent. When
// ion-content is present, it already handles bottom safe-area via
// its own scroll container — applying it again at the wrapper level
// creates double compensation (visible as a white gap on iOS).
// Custom modals with raw HTML are fully developer-controlled and
// should not be modified.
if (hasContent || hasFooter) return;

// Reduce wrapper height by safe-area and add equivalent padding so the
// total visual size stays the same but the flex content area shrinks.
Expand Down