Added prefix parameter to IPv6.parse_data#28
Open
hannesg wants to merge 1 commit intoipaddress-gem:masterfrom
Open
Added prefix parameter to IPv6.parse_data#28hannesg wants to merge 1 commit intoipaddress-gem:masterfrom
hannesg wants to merge 1 commit intoipaddress-gem:masterfrom
Conversation
Contributor
|
Hello, this is an old PR! Can you please rebase this branch of top of master so that the test suite is run? Also, GitHub can allow maintainers to add commits into your branch. This would allow us to rebase for you. If you want to benefit from this, please enable this feature (on the PR page, at the bottom of the right column, under the participants list, check Allow edits from maintainers.)? Thanks! |
smortex
requested changes
Aug 30, 2017
Contributor
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Add review to request a rebase on top of master.
TheHolyRoger
pushed a commit
to whatagem/ipaddress
that referenced
this pull request
Oct 18, 2021
…arize Remove dup from ipv6 summarize to give small performance boost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
IPv6.parse_data is the only parse method which doesn't have a prefix parameter. I added it to make to improve consistency.
Cheers
Hannes