Make eql? behare like ==.#77
Merged
bluemonk merged 2 commits intoipaddress-gem:masterfrom Jan 8, 2022
smortex:eql
Merged
Conversation
~~~
IPAddress.parse('::1') == IPAddress.parse('::1') #=> true
IPAddress.parse('::1').eql? IPAddress.parse('::1') #=> false
~~~
~~~
IPAddress.parse('::1') == IPAddress.parse('::1') #=> true
IPAddress.parse('::1').eql? IPAddress.parse('::1') #=> true
~~~
Contributor
Author
|
For the records, #22 also partially handles this by defining methods (and does more) but no news from submitter. Either I missed that other PR when opening this one, or I wanted to follow more strictly the "tradition" by aliasing 😉 |
|
@kaoudis can this get merged ? |
Contributor
Author
|
And new please release it too, last release is from 2016 :D
…On Sat, Jan 8, 2022 at 2:15 AM Marco Ceresa ***@***.***> wrote:
Merged #77 <#77> into
master.
—
Reply to this email directly, view it on GitHub
<#77 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACYZ6N2ZQRDAK72SMNTY3UVAFCPANCNFSM4B6RVVKA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoting
Object#eql?