fixes for PR #51 add/subtract methods from @victorhahncastell#79
Open
lumean wants to merge 15 commits intoipaddress-gem:masterfrom
Open
fixes for PR #51 add/subtract methods from @victorhahncastell#79lumean wants to merge 15 commits intoipaddress-gem:masterfrom
lumean wants to merge 15 commits intoipaddress-gem:masterfrom
Conversation
… instead of minitest for Ruby > 1.9.0
Conflicts: ipaddress.gemspec test/test_helper.rb
removed return statements reverted unnecessary indentation changes changed ArgumentError to RuntimeError for add method
lumean
changed the title
|
@lumean: Thanks for your commit. I think we all need this feature. |
|
Do you have any updates regarding this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is the continuation of Pull-request #51 all the work is from @victorhahncastell. I don't want to take any credits. Just like to push integration into upstream gem, so I've forked his commits and integrated the desired changes. Unit tests are passing with minitest.
I was not sure about the parens for all the assert_equal methods, for consistency reasons I don't think it makes sense to add parens only for the new test-methods of this PR. Let me know if you want the parens, then I'll add them. Can also add them for all other existing testmethods if you want me to.